search

MahApps / MahApps.Metro.IconPacks

Awesome icon packs for WPF and UWP in one library
MIT License
1.77k stars 222 forks source link

IconPacks for Uno Platform #238

Open byrialsen opened 4 years ago

byrialsen commented 4 years ago

[Feature request] Could be nice to be able to use IconPacks for the Uno Platform.

punker76 commented 4 years ago

@byrialsen Sounds interesting, I'll look for this. But need some learning about Uno and how to create packages for it.

ParthMandalia commented 4 years ago

I am creating MahApps Icon pack browser (from the browser already available in this repo) in Uno platform. I have UWP version running. If there is support for Uno, probably this application will support all the platforms ( IOS, Android, WebAssembly, UWP and Linux).

Design will be polished based on different form factor. 1

Thanks

punker76 commented 4 years ago

@pdm19882004 Can you point me to the repo? It would be nice to see the code. 👍

ParthMandalia commented 4 years ago

@pdm19882004 Can you point me to the repo? It would be nice to see the code. 👍

I am currently Uploading it and will post the repo link here.

Thanks

ParthMandalia commented 4 years ago

https://github.com/pdm19882004/MahAppIcons

(First commit in Github. Sorry if made any mistakes and I hope my Naming of project is not the problem like taking credit of this Project or something)

timunie commented 4 years ago

Hi @ParthMandalia

The idea is great and your first draft is IMO beautiful. But there is more to consider, so for now we want to stick with the current design. Nevertheless we can discuss yours when the uno support is implemented. :-)

(First commit in Github. Sorry if made any mistakes and I hope my Naming of project is not the problem like taking credit of this Project or something)

Please do us (and you) a favour: Instead of creating your own repo for it and copy / paste all the stuff there, fork this repo and create a new branch for your idea. This would make it possible to merge it if it is ready some day.

Happy coding Tim

ParthMandalia commented 4 years ago

Please do us (and you) a favour: Instead of creating your own repo for it and copy / paste all the stuff there, fork this repo and create a new branch for your idea. This would make it possible to merge it if it is ready some day.

I have forked this repo and created a branch. I am not sure for the next steps. Please guide me.

ParthMandalia commented 4 years ago

I was able to partially build Uno class library for this project. I have only used one icon pack (BoxIcon) to test the project as of now. Since there are many projects to build (15 projects {3 projects with Android, UWP, WASM, IOS, Mac each}), there is a randomly generated bug (Uno.SourceGenerationTasks.targets) in any one of the project and entire library fails to build. Should I upload the project solution here? Note: I have removed all the WPF components from the project.

ParthMandalia commented 3 years ago

I was able to successfully compile the MahAppsIcons UNO class library locally (without github). And trying to link the project with my master branch.

I dont know what changes are required in Directory.builds.props / *.csproj files

Error Could not copy the file "\packages\mahapps.metro.iconpacks\3.0.0\lib\uap10.0.17763\MahApps.Metro.IconPacks.BoxIcons\Themes\Generic.xbf" because it was not found.