Themes.xaml --> Sould it be Gray or Grey?

[timunie]

Describe the bug I really like the way the theme resources are called now, because it is more intuitive. But what i don't understand is, the Name of the Gray Brushes.

Have a look in the file Theme.xaml:

    <SolidColorBrush x:Key="MahApps.Brushes.SemiTransparentGrey" Color="#40808080" options:Freeze="True" />

[....]

    <SolidColorBrush x:Key="MahApps.Brushes.Gray1" Color="{StaticResource MahApps.Colors.Gray1}" options:Freeze="True" />

To Reproduce Just have a look here: https://github.com/MahApps/MahApps.Metro/blob/develop/src/MahApps.Metro/Styles/Themes/Theme.Template.xaml

Expected behavior I am not a native english speaker, so I cannot tell you which spelling for gray or grey is the correct version. But we should use only one version imo.

Screenshots If applicable, add screenshots to help explain your problem.

Environment(please complete the following information):

• MahApps.Metro version 2.0.0 latest alpha

Happy coding Tim

[makingbloke]

I vote for grey being a British English speaker :) too much Americanisation of our language going on lol ;)

On Mon, 19 Aug 2019 at 07:46, Tim notifications@github.com wrote:

Describe the bug I really like the way the theme resources are called now, because it is more intuitive. But what i don't understand is, the Name of the Gray Brushes.

Have a look in the file Theme.xaml:

<SolidColorBrush x:Key="MahApps.Brushes.SemiTransparentGrey" Color="#40808080" options:Freeze="True" />

[....]

<SolidColorBrush x:Key="MahApps.Brushes.Gray1" Color="{StaticResource MahApps.Colors.Gray1}" options:Freeze="True" />

To Reproduce Just have a look here:

https://github.com/MahApps/MahApps.Metro/blob/develop/src/MahApps.Metro/Styles/Themes/Theme.Template.xaml

Expected behavior I am not a native english speaker, so I cannot tell you which spelling for gray or grey is the correct version. But we should use only one version imo.

Screenshots If applicable, add screenshots to help explain your problem.

Environment(please complete the following information):

• MahApps.Metro version 2.0.0 latest alpha

Happy coding Tim

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MahApps/MahApps.Metro/issues/3575?email_source=notifications&email_token=ABPMCPJOXNFZZVM33GVD4XDQFI6UDA5CNFSM4IMYPFNKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HF4ZC5Q, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPMCPLZGJ2BW2AELTSBX4TQFI6UDANCNFSM4IMYPFNA .

[amkuchta]

@makingbloke the fact that you have "bloke" in your username confirms that you are, in fact, British.

As an American, I actually side with @makingbloke - I personally prefer the British spelling of the word.

[punker76]

@timunie The Grey was introduced by this PR.

I would prefer changing this to Gray because it's just these 2 places.

[timunie]

@punker76 I think you are right. Then it would be easier for other people, too.

Happy coding Tim

[Evangelink]

Usually in IT american english wins over british ;)

[makingbloke]

Hey we’ve got to give them some concession :) Us Brits invented the language - the Americans bastardised a dialect lol :)

On Tue, 27 Aug 2019 at 14:26, Amaury Levé notifications@github.com wrote:

Usually in IT american english wins over british ;)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MahApps/MahApps.Metro/issues/3575?email_source=notifications&email_token=ABPMCPNY364WBSCIIYU46NTQGUTQXA5CNFSM4IMYPFNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5HXEJQ#issuecomment-525300262, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPMCPLQR7EC35URZHY7R3DQGUTQXANCNFSM4IMYPFNA .

[daiplusplus]

(I'll preface my answer by saying I'm British myself, albeit living in Microsoft's back-yard in Redmond)

Putting national-pride aside - the official .NET Framework Style Guidelines do make it clear that en-US spelling should always be preferred, and because it's consistent with the main .NET class libraries which use en-US spelling, especially in System.Drawing.Colors where it's Gray, not Grey, sorry: https://docs.microsoft.com/en-us/dotnet/api/system.drawing.color.gray?view=netcore-3.1

I feel a small insignificant cringe in my head whenever I review Unity (game-engine) code because they named one their main interfaces Behaviour rather than Behavior - not at all because it's not en-GB (or en-AU, en-CA etc), but because of the fact it's inconsistent - and I'd rather not feel the same way when I'm using the otherwise wonderful MahApps.Metro library.

I can imagine a non-native English speaker who might be completely oblivious to the differences between Grey and Gray who is converting WinForms+GDI code to WPF+MahApps.Metro at 3am and just pounding their head on the keyboard because their code won't compile because they didn't expect something as simple as colour names to be arbitrarily different compared to the rest of the .NET library ecosystem.

I vote for grey being a British English speaker :) too much Americanisation of our language going on lol ;)

If we want MahApps.Metro to counter Americanism (I won't go as far as saying "cultural imperialism"[1]) in the software industry it should be by embodying the best parts of British values, not something as patently silly as spelling. Pink Floyd said it best in 1973:

Hanging on in quiet desperation is the English way

...but I'll also settle for the MahApps.Metro library including an animated GIF of Queen Liz and her corgis as an easter-egg hidden inside the main assembly.

[1] And that would be inexcusable coming from me as someone who directly-indirectly benefited from the spoils of the days of Empire...