search

MahApps / MahApps.Metro

A framework that allows developers to cobble together a better UI for their own WPF applications with minimal effort.
https://mahapps.com
MIT License
9.28k stars 2.45k forks source link

Font Naming Convention #3584

Closed amkuchta closed 4 years ago

amkuchta commented 5 years ago

Is your feature request related to a problem? Please describe.

Looking through the new naming conventions, Fonts are structured as follows:

I think that this is namespacing is inconsistent, and that a small update could make things easier for other users to follow.

Describe the solution you'd like

I suggest updating to the following naming convention for consistency:

This creates a more consistent (and therefore easier to use) namespacing.

Additional context

N/A

Closed Issues

N/A

amkuchta commented 5 years ago

@punker76 if you agree with this, I can create a PR to clean it up.

punker76 commented 5 years ago

/cc @Evangelink WDYT?

Evangelink commented 5 years ago

Yeah :D I was having the same feeling when working on adding MUI styles.

amkuchta commented 5 years ago

Should I go ahead and create a PR, @punker76 & @Evangelink? And if so, would you like me to break out the namespace a bit more to make room for MUI, perhaps like so:

Evangelink commented 5 years ago

That's ok on my side @amkuchta! Regarding the .Default suffix, it's up to you, I was a bit out of time lately to make progress on MUI.

amkuchta commented 5 years ago

I just think it would be nice to have all of the names go to the same depth, and Default tells users what the normal value would be for MA.M vs MA.M's implementation of MUI (or any other style that may be included in the future)