MahanRahmati / translate

Alternative front-end for Google Translate which respects your privacy.
GNU General Public License v3.0
110 stars 8 forks source link

F-Droid #2

Open MahanRahmati opened 2 years ago

MahanRahmati commented 2 years ago

@IzzySoft Hello there! πŸ‘‹ How can I add my application to your repo and F-droid?

IzzySoft commented 2 years ago

You can't – but I can :wink: Just doing so at this very moment for my repo. Some questions & suggestions:

Your app will show up here with the next sync (around 6 pm UTC). If we can get in some screenshots before, it will be presented in all its glory – otherwise, the glory needs to be added later. If you wonder about NonFreeNet: though used indirectly, Google Translate is a non-free network service (it's not "free" in the sense of "libre"). But no worries, same applies to NewPipe etc :wink:

As for F-Droid: once we've got screenshots etc. ready I suggest I prepare a PR for you here to establish fastlane structures, to make description etc. available for F-Droid. Once that's merged, you can go ahead and request packaging.

MahanRahmati commented 2 years ago

@IzzySoft Thanks for your kind reply. Screenshots are inside .github folder. btw I renamed applicationId to "com.arna.translate".

IzzySoft commented 2 years ago

Thanks! Renaming came just in time (so I can replace it before it goes online). But you again forgot to increase versionCode. If you don't do that for future versions, updates will fail.

I've sent you my setup of metadata via PR #3 – you will need that for F-Droid.org. Once merged, I'll update the configuration in my repo to check and pull changes along with new releases then. I hope you don't mind that I "unframed" your screenshots – but on small screens (smartphones), the border is wasting far too much screen estate, making it impossible to see the real screenshot :wink:

MahanRahmati commented 2 years ago

@IzzySoft Thanks for your PR. I merged it and pushed new screenshots to repo. Did 1bbcc85 fixed versionCode?

IzzySoft commented 2 years ago

I merged it and pushed new screenshots to repo.

Thanks! Will have a look now and enable it in my config here.

Did 1bbcc85 fixed versionCode?

versionCode must be fixed here:

version: 2.0.1+6

Note the +6 (I picked 6 as this is the 6th release then); syntax is version: <versionName>+<versionCode>. If no versionCode is defined, Flutter always defaults to 1.

IzzySoft commented 2 years ago

Oops, something must have worked – I just see a com.arna.translate_20001.apk was picked an hour ago \o/ TIL: there are more ways to define versionCode with Flutter than I was aware of. All looks fine then! So if you wish to proceed to F-Droid.org, you can go ahead and request packaging there.

MahanRahmati commented 2 years ago

https://gitlab.com/fdroid/rfp/-/issues/2113

IzzySoft commented 2 years ago

Yepp, thanks! Just fixed up your initial comment (had to remove all Github links except the one to the app's repo itself as the bot didn't know which to pick). Issuebot report should appear soon. As we ironed out most things already, I expect it to look good :smile:

MahanRahmati commented 1 year ago

@IzzySoft Hello there! Do I need to do anything else to add the app to the main repo?

IzzySoft commented 1 year ago

It's marked ready for packaging – so you can either wait for a packager to pick it up, or push forwards using the YAML I provided and open a merge request with it at fdroiddata (file location I specified). That would speed things up a bit.

IzzySoft commented 1 year ago

@MahanRahmati looks like you weren't notified: The MR at F-Droid is currently stuck waiting for a slignt adjustment here:

CheckUpdates needs an adjustment in pubspec.yaml (versionCode part is missing there). Asked the submitter in the RFP to check. Also mentioned Flutter as git submodule and possible per-ABI builds there.

Could you please check? That line in pubspec.yml should be version: <versionName>+<versionCode>, the latter part is currently missing.

MahanRahmati commented 1 year ago

@IzzySoft oh sorry about that! I will fix it! πŸ˜…πŸ˜…

IzzySoft commented 1 year ago

Great, thanks! Please give me a ping when done so I can update the YAML (OMG, why did I pick v2.0.1? Did I mean v2.1.0?) Maybe there'll be a v2.1.1 then even? v2.1.0 is from 8/2022 and there hasn't been another release since. Just asking; trouble is your fix will only be accepted when it can be seen at the tag/commit we build from, so we'd need to pick the latest one then anyway (or just ignore the fail for now seeing it should work next time – but a recent version would be great and IMHO the better solution, if possible).

IzzySoft commented 1 year ago

Hi @MahanRahmati – any news on this? You promised to fix this 4 months ago, but it's still not fixed. We cannot merge this at F-Droid.org before its fixed, so is there any chance it will happen anytime soonβ„’?

MahanRahmati commented 1 year ago

Hi @IzzySoft. I'm going to do a big refactor soon. Right now I'm trying to create tools so that transition to the new code base would be as simple as possible.

IzzySoft commented 1 year ago

Thanks for your answer! Any ETA when you think we can proceed then? For now a due-date is set a month from now. As a rewrite might take more than that, I could see that we lift it a bit. How much should we do that before sending you a "heads up"?

MahanRahmati commented 1 year ago

https://github.com/MahanRahmati/flutter_boilerplate_app is nearly done. It will be the base for the new code base. I can't give an ETA right now, but I'm going to start the refactor this week.

IzzySoft commented 1 year ago

Thanks for the answer! Then I wish best progress – and let the current due-date stand as it is (as a reminder to check). When you can give an update, we can lift/move it anytime.

MahanRahmati commented 12 months ago

@IzzySoft 2.1.1 is out. Can you check if it fixes f-droid?

IzzySoft commented 12 months ago

Checking now. One thing that becomes an issue is

version: 2.1.1+1

You'll need to increase versionCode (the part following the +) with each release, or the updater won't pull new versions as it thinks it's already there. Please remember that for the next release (for the initial one, we can stick with 1 for now).

I've just bumped the commit in the YAML and pushed that, CI/pipelines are currently running.

IzzySoft commented 12 months ago

Build fails:

Because translate depends on flutter_localizations from sdk which depends on intl 0.17.0, intl 0.17.0 is required.
So, because translate depends on intl ^0.18.0, version solving failed.

Ideas?

MahanRahmati commented 11 months ago

@IzzySoft I think there are more problems with the app right now. I found some bugs in my boilerplate and I need to upgrade Arna. 😞

IzzySoft commented 11 months ago

Oof. :crossed_fingers: then and good progress!

IzzySoft commented 10 months ago

@MahanRahmati your last release no longer has an APK attached and thus did not even reach my repo (oh, also because your tag name no longer starts with v). Will you add it please? The APK I mean (the v would be welcome too, but if you do not want to have that anymore, I can also update my config accordingly).

DiagonalArg commented 7 months ago

I draw my .apk from github via Obtainium, so I would also appreciate that appearing here.

vishalscodes commented 2 months ago

I too would like the apk to be available at the releases page for the same Obtanium purposes just like @DiagonalArg.