MaharaProject / moodle-assignsubmission_mahara

Old, unmaintained Mahara assignment submission plugin for Moodle
https://moodle.org/plugins/view/assignsubmission_mahara
4 stars 10 forks source link

Restoration of a deleted Mahara assignment will not lock up pages again #10

Open MelvRom opened 9 years ago

MelvRom commented 9 years ago

When a Mahara assignment containing submitted pages is deleted and then restored. The pages will not be locked again in Mahara. To reproduce:

*Assuming that the "Lock submitted pages" option is at "Yes" with the "Mahara Feedback" checked.

  1. As a student, go to the Mahara assignment and submit a page or pages.
  2. As a teacher, make a backup of your course only with the Mahara assignment. You must include user data.
  3. Delete the assignment.
  4. As a student, check that the page (or pages) was (were) unlocked in Mahara.
  5. As a teacher, restore the course with the .mbz file.
  6. Check that the assignment is now available again and that student’s page(s) is (are) back as well.
  7. As a student, check that your page(s) that you previously sent for evaluation is now locked again in Mahara. (this does not happen).

Result: It seems that the page(s) is (are) not locked anymore which might be a problem for many users. I am using Moodle 2.7.3 and Mahara 1.10.2.

upats commented 9 years ago

hi @MelvRom ,

There are some pull requests awaiting a merge into the master branches of the plugins. These updates have reworked the locking/unlocking mechanism. You may want to try this newest version after they've been merged to see if this still happens. You will no longer need the feedback plugin as all events are handled within the assignsubmission plugin instead.

The lock/unlocking feature now relies on event triggers to lock/unlock portfolios. I don't know what the moodle events triggers are like when restoring backed up courses... It seems kind of unlikely that it would fire a "submission" event on a restore, so we may still need to address this issue.