search

MahdiF / loud-links

:sound: A simple tiny Javascript library to add interaction sounds to your website.
https://mahdif.github.io/loud-links/
MIT License
725 stars 60 forks source link

Audible clicks in Chrome #12

Open bentstamnes opened 8 years ago

bentstamnes commented 8 years ago

It appears as if the playback isn't faded either in nor out and that the playback is just immediately stopped (for example when re-clicking the demo button, or hovering over the other demo button and then moving the mouse pointer), which produces severe clicks.

There should probably be fading towards DC 0 to avoid these clicks, and that sounds like it should be in the playback library, and not rely on the audio files (which is probably impossible to maintain anyway, given that any sound can be stopped at any time :)

MahdiF commented 8 years ago

I didn't write a fade in/out function, it stops the first sound and plays the next one when you hover/click something else.

bentstamnes commented 8 years ago

Alright, so at least my intuition was right then. :) I think it would greatly benefit a sharp fade out on audio playback stop, especially since this seems to be directed at interface sounds which usually might not overlap much.

MahdiF commented 8 years ago

That's actually a great suggestion! Thanks Bent :)

On Wed, Jun 29, 2016 at 2:14 PM, Bent Stamnes notifications@github.com wrote:

Alright, so at least my intuition was right then. :) I think it would greatly benefit a sharp fade out on audio playback stop, especially since this seems to be directed at interface sounds which usually might not overlap much.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MahdiF/loud-links/issues/12#issuecomment-229338394, or mute the thread https://github.com/notifications/unsubscribe/AEArpTQYtFql850cJNQ3s5pAj2lBN5uvks5qQmGvgaJpZM4JBEHH .

bentstamnes commented 8 years ago

Happy to suggest it! 👍 :)