search

MahdiMirzade / Dotfiles

🌸 Configuration for i3, kitty, picom, ZSH, gtk, qutebrowser, qbittorrent and more... (All tools for an arch linux new installation)
GNU General Public License v3.0
48 stars 8 forks source link

[REQ] Qbittorrent dark theme different icon colors for stalled up/download #1

Closed mzso closed 2 years ago

mzso commented 2 years ago

Hi! I got here via list of themes from the QBs repository. I was wondering whether you plan on enhancements to the theme?

My main annoyance is that the stall up and downloads are the same color which makes it rather hard to tell them apart.

Also (I don't have high hopes for this) I wonder if you would consider other color variants of the theme. I rather prefer warm hues, especially on a dark theme instead of blue.

MahdiMirzade commented 2 years ago

Hello mzso, Sorry for the late reply.

I updated the theme, it now has better icon pack and WebUI support. You can find this theme on its new repository now. I don't think I'll update the theme in this repository ever again and my next push to my personal dotfiles will delete it.

My main annoyance is that the stall up and downloads are the same color which makes it rather hard to tell them apart.

It might be the theme update, but stalled uploading and downloading colors are completely different, will the new .qbtheme file fix it? image If you want to make changes to the the theme you can create a PR on the new repository with screenshots.

Also (I don't have high hopes for this) I wonder if you would consider other color variants of the theme. I rather prefer warm hues, especially on a dark theme instead of blue.

That is actually something I've been working on some months ago, but not designing new variants but generating them. Basically I want to generate the .qss files using my .Xresources and create qbittorrent themes from them. (gruvbox-dark, nord, oceanic-next, onedark, etc) I got lost in the design and generating new variants process that I left the project, I might get back to it soon and will update you in this issue. (no promises)

Best Regards, Mahdi

mzso commented 2 years ago

@MahdiMirzade Hi! The stalled up a downloads are still identically colored. Also shown on your preview: kép Every other status seems to have a unique color.

MahdiMirzade commented 2 years ago

I played with the SVGs a little bit and came up with something like this, I'm not really good with coloring but I think this is better than before, I updated the icons at https://github.com/MahdiMirzade/qbittorrent/commit/d2e216d271779bc21b6ad29fcb89a492a76e214e . Would this fix it?

image

mzso commented 2 years ago

@MahdiMirzade commented on 2022. márc. 26. 17:54 CET:

I played with the SVGs a little bit and came up with something like this, I'm not really good with coloring but I think this is better than before, I updated the icons at MahdiMirzade/qbittorrent@d2e216d .
Would this fix it?

image

It's certainly different now. I think the "Stalled download" should be less saturated than "Downloading" otherwise it might get confusing. Maybe something like this? kép

(I'm not good with colors either...)

MahdiMirzade commented 2 years ago

It's certainly different now. I think the "Stalled download" should be less saturated than "Downloading" otherwise it might get confusing.

I agree, but I was worried that it would be too bright and turn out wierd.

Maybe something like this?

I played a little bit more, and this is something I thought might just pass the test: image Would this do? (It's not pushed to the repo yet)

mzso commented 2 years ago

@MahdiMirzade

I was worried that it would be too bright and turn out wierd.

Not sure what you mean by that.

I played a little bit more, and this is something I thought might just pass the test:

Would this do? (It's not pushed to the repo yet)

Fine by me. I suggested a more faded color thinking it would be less confusable with the "downloading" state.

MahdiMirzade commented 2 years ago

Fine by me. I suggested a more faded color thinking it would be less confusable with the "downloading" state.

Pushed to the repo on https://github.com/MahdiMirzade/qbittorrent/commit/db5a48843a454cb1df0f51ef2fe1118dd00626d8, you can now download the new .qbtheme theme file. Also if it turned out to met your expectations, you can close this issue.

Kind Regards, Mahdi

mzso commented 2 years ago

@MahdiMirzade commented on 2022. márc. 29. 22:14 CEST:

Fine by me. I suggested a more faded color thinking it would be less confusable with the "downloading" state.

Pushed to the repo on MahdiMirzade/qbittorrent@db5a488, you can now download the new .qbtheme theme file.
Also if it turned out to met your expectations, you can close this issue.

Kind Regards, Mahdi

Thanks!