search

Mahdisadjadi / arxivscraper

A python module to scrape arxiv.org for a date range and category
MIT License
282 stars 53 forks source link

Adding the option to terminate scraping early #4

Closed azqanadeem closed 5 years ago

azqanadeem commented 5 years ago

When creating an instance of the arxivscraper, the user can now add timeout=x to request the scraping to terminate after about x seconds.

Mahdisadjadi commented 5 years ago

@azqa : Thank you so much for your contribution, this is a great addition. Two notes:

  1. Don't think 30 seconds is a bit small? Maybe 2 min = 120 s is better?
  2. Can you also add the default value to the docstring?

Thanks again!

Mahdisadjadi commented 5 years ago

@azqa : Thank you so much for your great contribution. I merged the PR.