search

MaherKSantina / MSPeekCollectionViewDelegateImplementation

A custom paging behavior that peeks the previous and next items in a collection view
https://medium.com/@maher.santina90/how-to-create-cells-that-peek-on-the-sides-like-ios-11-app-store-ef4bb54c0c7d
MIT License
356 stars 32 forks source link

Updated for Swift 4.2 #39

Closed digitaljerry closed 5 years ago

MaherKSantina commented 5 years ago

Much appreciated @digitaljerry 🥇 ! I'll test this when I get back home and merge it

Luccifer commented 5 years ago

@MaherKSantina any news?

MaherKSantina commented 5 years ago

@Luccifer I'm on my way home give me an hour and I'll test it out. I need to also fix the failing tests. Thank you for the message!

MaherKSantina commented 5 years ago

@digitaljerry I need to do some changes on this PR to make it work is it okay to push my changes to your branch?

digitaljerry commented 5 years ago

@MaherKSantina sure. Go ahead. Btw, I did this to make it compatible with XCode 10.2 which no longer supports Swift 3.x.

MaherKSantina commented 5 years ago

@digitaljerry yeah I figured, I should have upgraded this pod long ago. I'll do it now and make a release. Thank you so much for the contribution!

MaherKSantina commented 5 years ago

@digitaljerry version 1.2.0 is live with swift 4.2 included!

digitaljerry commented 5 years ago

Awesome. Thanks @MaherKSantina for a fast release. Deleting my fork.

MaherKSantina commented 5 years ago

@digitaljerry no worries mate! Have a good day!