search

MaherKSantina / MSPeekCollectionViewDelegateImplementation

A custom paging behavior that peeks the previous and next items in a collection view
https://medium.com/@maher.santina90/how-to-create-cells-that-peek-on-the-sides-like-ios-11-app-store-ef4bb54c0c7d
MIT License
356 stars 32 forks source link

iOS 9.3 support #40

Closed NEXTKING closed 5 years ago

NEXTKING commented 5 years ago

Hello, thanks for this nice implementation, but why did you drop support of iOS 9.3 starting from v. 1.2.0? It works perfectly on iOS 9 and no need for additional legacy code.

MaherKSantina commented 5 years ago

Hello @NEXTKING ! Thanks for raising the issue! I didn't know that some developers are still on iOS 9.3 as its market share is very low (2.9%). But you're right it's working anyways on that version so I shouldn't drop it. I'll make a release to restore that support! Sorry for the inconvenience!

NEXTKING commented 5 years ago

I agree that the share is non-significant and personally I would drop it myself, but there are still a lot of people using iPod 5th generation (I bet especially for enterprise apps) which can't be upgraded more than 9.3. Thank you!

MaherKSantina commented 5 years ago

@NEXTKING version 1.2.1 is live and supports iOS 9! 🎉 Thanks for raising this issue. Feel free to close it when you test the new version and confirm it's working! 👍

MaherKSantina commented 5 years ago

I agree that the share is non-significant and personally I would drop it myself, but there are still a lot of people using iPod 5th generation (I bet especially for enterprise apps) which can't be upgraded more than 9.3. Thank you!

Ohh that's a good note I'll keep that in mind!

NEXTKING commented 5 years ago

Everything's fine now, thank you again!

MaherKSantina commented 5 years ago

No worries mate 👍 Thank you for your feedback!