search

Mahesh1772 / pe

0 stars 0 forks source link

DG Workout UML Run class #12

Open Mahesh1772 opened 5 months ago

Mahesh1772 commented 5 months ago

image.png

Missing attributes: date, isHourPresent.

All the attributes are protected, and hence must be represented by a "#".

method, splitRunTime() is missing form diagram. Does not have to be a part of the utility package?

nus-se-bot commented 5 months ago

Team's Response

Attributes are private based on latest Github release. isHourPresent is no longer an attribute part of Run. Not all methods are mentioned in class diagram intentionally as it will make the diagram too big and complex. Our TA mentioned only important methods should be mentioned, since developers can read the code themselves.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: As a tester or developer, my reliance on the accuracy of the documentation provided on GitHub is paramount. If I do not have access to the most recent changes—assuming they have not been pushed to the repository—I am left to work with potentially outdated information. This discrepancy can significantly affect my ability to accurately assess and interact with the codebase. It is crucial for the documentation to accurately reflect the current state of the code to prevent such issues.

The utility package is often a collection of tools that are essential for the operation of the system, and parsing functionality is typically a key component of such a package. If splitRunTime() is integral to the parsing operations, why is it not within the utility package?