Maheshjayachandran / closure-library

Automatically exported from code.google.com/p/closure-library
0 stars 0 forks source link

goog.events.EventTarget.removeEventListener should return succes bool just like goog.events.unlisten #368

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Have removeEventListener mirror goog.events.unlisten is goodness

Original issue reported on code.google.com by kev...@j832.com on 8 Sep 2011 at 9:35

Attachments:

GoogleCodeExporter commented 9 years ago
Adding another: addEventListener should allow string *OR* string array for type

Again, mirroring the API in goog.events

Original comment by kev...@j832.com on 7 Oct 2011 at 4:40

Attachments:

GoogleCodeExporter commented 9 years ago
Code review: http://codereview.appspot.com/5246043

Original comment by kev...@j832.com on 8 Oct 2011 at 11:21

GoogleCodeExporter commented 9 years ago
Cannot take patch without CLA.  See wiki page on contributors.

Original comment by nn...@google.com on 9 May 2012 at 11:02

GoogleCodeExporter commented 9 years ago
Sad. I submitted the CLA many moons ago, but got no response. I'll try again.

Original comment by kev...@j832.com on 9 May 2012 at 11:03

GoogleCodeExporter commented 9 years ago
WIll not take patch. EventTarget is meant to match W3C interface.

http://www.w3.org/TR/DOM-Level-2-Events/events.html#Events-EventTarget

Original comment by nn...@google.com on 9 May 2012 at 11:04

GoogleCodeExporter commented 9 years ago

Original comment by nn...@google.com on 9 May 2012 at 11:05

GoogleCodeExporter commented 9 years ago
EventTarget mirrors w3c event signature, not goog.events signature. Hence we 
aren't going to change the signature.

Original comment by chrishe...@google.com on 9 May 2012 at 11:05

GoogleCodeExporter commented 9 years ago
Annoying, but understood.

Original comment by kev...@j832.com on 9 May 2012 at 11:06