Closure Library will not compile with missing override checks turned on

[GoogleCodeExporter]

What steps will reproduce the problem?

1. Turn on reportMissingOverride to CheckLevel.ERROR
2. Compile Closure

What is the expected output? What do you see instead?

/usr/local/users/bmccann/closure/closure-library/closure/goog/base.js:1448: 
ERROR - property constructor already defined on superclass tempCtor; use 
@override to override it
  childCtor.prototype.constructor = childCtor;
  ^

/usr/local/users/bmccann/closure/closure-library/closure/goog/disposable/disposa
ble.js:105: ERROR - property isDisposed already defined on interface 
goog.disposable.IDisposable; use @override to override it
goog.Disposable.prototype.isDisposed = function() {
^

/usr/local/users/bmccann/closure/closure-library/closure/goog/disposable/disposa
ble.js:125: ERROR - property dispose already defined on interface 
goog.disposable.IDisposable; use @override to override it
goog.Disposable.prototype.dispose = function() {
^

/usr/local/users/bmccann/closure/closure-library/closure/goog/math/coordinate.js
:49: ERROR - property clone already defined on superclass Object; use @override 
to override it
goog.math.Coordinate.prototype.clone = function() {
^

/usr/local/users/bmccann/closure/closure-library/closure/goog/math/coordinate.js
:59: ERROR - property toString already defined on superclass Object; use 
@override to override it
  goog.math.Coordinate.prototype.toString = function() {
  ^

/usr/local/users/bmccann/closure/closure-library/closure/goog/math/size.js:67: 
ERROR - property clone already defined on superclass Object; use @override to 
override it
goog.math.Size.prototype.clone = function() {
^

/usr/local/users/bmccann/closure/closure-library/closure/goog/math/size.js:77: 
ERROR - property toString already defined on superclass Object; use @override 
to override it
  goog.math.Size.prototype.toString = function() {
  ^

externs.zip//html5.js:1663: ERROR - property toString already defined on 
superclass Object; use @override to override it
DOMTokenList.prototype.toString = function() {};
^

8 error(s), 0 warning(s), 94.7% typed

What version of the product are you using? On what operating system?

At revision 1441.

Original issue reported on code.google.com by benjamin...@gmail.com on 3 Dec 2011 at 8:15

[GoogleCodeExporter]

Patch attached.

Original comment by benjamin...@gmail.com on 6 Dec 2011 at 7:18

Attachments:

• overrides.patch

[GoogleCodeExporter]

Patch author has signed CLA.

Original comment by nn...@google.com on 11 May 2012 at 7:37

[GoogleCodeExporter]

I'll look into adding the flag into our compiler warnings test.

Original comment by chrishe...@google.com on 11 May 2012 at 7:37

[GoogleCodeExporter]

Btw, I did an internal cleanup for all of the missing @override (there are 500+ 
of them) and also remove Object.prototype.clone declaration in base.js (causing 
spurious missing @override for clone method).

These should have been reflected (or will be soon) in the svn repo. We also 
added a test internally to prevent more missing @override from being checked 
in. Marking as fixed.

Original comment by chrishe...@google.com on 9 Jun 2012 at 12:49

• Changed state: Fixed