search

Maheshjayachandran / closure-library

Automatically exported from code.google.com/p/closure-library
0 stars 0 forks source link

[patch] goog.History.HAS_ONHASHCHANGE should use feature detection instead of UA sniffing #417

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
goog.History.HAS_ONHASHCHANGE is currently a property implemented with user 
agent sniffing. I propose it be switched to use feature detection instead. The 
impetus for this request is the lack of HTML5 History support on Android 4; see 
<http://code.google.com/p/android/issues/detail?id=23979>.

Proposed patch: http://codereview.appspot.com/5630069/

Original issue reported on code.google.com by amat...@gmail.com on 6 Feb 2012 at 7:59

GoogleCodeExporter commented 9 years ago 
Is this ready for ingestion?  Code review appears to have stalled.

Original comment by nn...@google.com on 11 May 2012 at 7:58

GoogleCodeExporter commented 9 years ago 
It is ready for ingestion, there was an internal email thread on this.

Original comment by brenne...@google.com on 11 May 2012 at 9:38

GoogleCodeExporter commented 9 years ago

Original comment by chrishe...@google.com on 15 May 2012 at 10:45

GoogleCodeExporter commented 9 years ago

Original comment by nn...@google.com on 15 May 2012 at 10:46

GoogleCodeExporter commented 9 years ago 
As this is ready for ingestion per Brenneman, could someone please finish the 
process?

Original comment by amat...@gmail.com on 27 Aug 2012 at 4:22

GoogleCodeExporter commented 9 years ago 
Ping. Review is complete and patch is super tiny.

Original comment by amat...@gmail.com on 27 Feb 2013 at 10:22

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision 93bbce4acc22.

Original comment by nn...@google.com on 8 Mar 2013 at 11:29