search

MahjongRepository / mahjong

Implementation of riichi mahjong related stuff (hand cost, shanten, agari end, etc.)
MIT License
377 stars 38 forks source link

Suggestions of new features #25

Closed profthecopyright closed 2 years ago

profthecopyright commented 3 years ago

I just found this repo. Wonderful!

  1. Should we include honba （本場）numbers into HandConfig for adjustment of cost calculations?
  2. Should we include the tiles that lead to less shanten number in the return value of the shanten calculator so that it would be the same as in [url]https://tenhou.net/2/
Nihisil commented 3 years ago

Thanks for the suggestions. I don't mind if these features will be added to the lib code.

profthecopyright commented 3 years ago

OK thanks I will take care of this. And also, could I add a Chinese version of the docs and the yaku names so that Chinese majhong players (and programmers) can use this library more easily?

Nihisil commented 3 years ago

Sure! Thanks. Maybe while you are here you integrate some localization system, so we will have separate localization files for yaku names instead of name_en, name_jp attributes.

profthecopyright commented 3 years ago

OK I can try to do the locale system in the next version.

Enerccio commented 3 years ago

If you are adding honba, don't forget basengo (5x increase) as optional rule too

profthecopyright commented 3 years ago

basengo

Good reminder. I am currently working on an optional rule supporting system, as there would be a lot more optional rules to include such as syuugi, etc.