search

MahjongRepository / mahjong

Implementation of riichi mahjong related stuff (hand cost, shanten, agari end, etc.)
MIT License
377 stars 38 forks source link

add yaku levels #32

Closed profthecopyright closed 3 years ago

profthecopyright commented 3 years ago

Sorry I was out in the last few days. It seems that someone has added optional rules already, so I think its better to synchronize before my branch goes further apart. Now I have not done substantial modifications to the optional rules part, and what I have done since last PR is adding yaku level (yakuman, baiman, mangan, etc) reporting in the text reporter function and hand response data structures. Hope this part could be merged and I can work along the latest version.

Nihisil commented 3 years ago

There are multiple conflicts, mainly because of changed code format.

I can resolve this conflicts in your branch if you don't mind.

profthecopyright commented 3 years ago

There are multiple conflicts, mainly because of changed code format.

I can resolve this conflicts in your branch if you don't mind.

I will appreciate it if you do so, since I am not familiar with the (make lint) or (make format stuff). Is that some GNU commands?

Nihisil commented 3 years ago

I will appreciate it if you do so, since I am not familiar with the (make lint) or (make format stuff). Is that some GNU commands?

They are shortcuts for isort (sorting for imports) and black (python code format) tools: https://github.com/MahjongRepository/mahjong/blob/master/Makefile