search

MahjongRepository / mahjong

Implementation of riichi mahjong related stuff (hand cost, shanten, agari end, etc.)
MIT License
377 stars 38 forks source link

fix: make lint #46

Closed 0num4 closed 1 year ago

0num4 commented 1 year ago

hello, I am developing mahjong bot and app and so on. While using this mahjong library, I noticed that I was getting an error when setting up the development environment etc., so I will send a PR. I'm interested in pydantic and may issue a separate PR. thanks.

Nihisil commented 1 year ago

hank you for contributing. I plan to integrate pydantic myself and improve the project's architecture. There will probably be a 2.0 version that is not compatible with the previous version. I am making progress on it, and I hope to release the first development version in the coming weeks.

Nihisil commented 1 year ago

@0num4 the version with your fix was released: https://pypi.org/project/mahjong/1.2.1/

0num4 commented 9 months ago

@Nihisil Sorry for the late reply. Thanks for approve! I've made my repository public as well, if you'd like to take a look. https://github.com/0num4/mahjong_ts/tree/main