search

Mahlet-Inc / hobbits

A multi-platform GUI for bit-based analysis, processing, and visualization
https://mahlet-inc.github.io
MIT License
660 stars 45 forks source link

An insecure fix for unworking reloading of KS specs. #122

Closed KOLANICH closed 3 years ago

KOLANICH commented 3 years ago

If we don't want specs with certan names be able to override system packages, importing must be done a bit different. In the first place, in the way not modyfying sys.modules. And I'd like it not to touch disk at all. In kaitaiStructCompile there is an impl not touching disk, but it has problems with reloading (in fact it was pretty hard to debug even loading, I had to implement a tool called FrozenTable.py (patching python binary/shared library executable because import machinery bytecode is hardcoded into binary) to do that).

hello-adam commented 3 years ago

:tada: This PR is included in version 0.51.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: