search

Mahlet-Inc / hobbits

A multi-platform GUI for bit-based analysis, processing, and visualization
https://mahlet-inc.github.io
MIT License
660 stars 45 forks source link

Replace FFTW library with the PFFFT library #126

Closed melissascode closed 2 years ago

melissascode commented 3 years ago

The FFTW library was utilized in two Hobbits plugins, the Spectrogram and the Width Framer. Due to licensing conflicts, the FFTW library could no longer be used in Hobbits. After researching different libraries, @hello-adam and I decided to use the PFFFT library.

I have refactored the code for both the Spectrogram and the Width Framer. Also, I implemented a QComboBox that allows users to change the FFT Size within the Spectrogram. Prior to adding this, FFT Size was a QSpinBox that allowed users to manually enter the FFT size or use up and down arrows to increment. The QComboBox allows users to choose FFT sizes in powers of two, ranging from 2^5 to 2^14 (or, 32 to 16,384).

hello-adam commented 3 years ago

I need to update the CentOS7 docker container to have pffft (that's why it's failing in azure). You might need to make changes to the CMake stuff after I do that in order to get that behaving correctly.

I'm not sure why the Ubuntu build failed.

hello-adam commented 3 years ago

looks like there are still references to CONAN_PKG::fftw that need to be removed

melissascode commented 3 years ago

looks like there are still references to CONAN_PKG::fftw that need to be removed

I removed them now and it looks like the checks were all successful. I will message you about how I should get other mentions of FFTW taken out other files I've seen it mentioned in.

hello-adam commented 2 years ago

:tada: This PR is included in version 0.53.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: