Mahlet-Inc / hobbits

A multi-platform GUI for bit-based analysis, processing, and visualization
https://mahlet-inc.github.io
MIT License
670 stars 46 forks source link

hobbits-runner shouldn't need a display? #151

Open jakecrowley opened 2 years ago

jakecrowley commented 2 years ago

I have limited knowledge of Qt so I'm not sure if this is even possible with the way hobbits-runner is implemented currently, but it for some reason still needs a display to run, even though it is a purely CLI tool. When trying to run it over SSH i get the error in the screenshot below.

hobbits-runner

hello-adam commented 2 years ago

it looks like the CI tests solve this by passing the argument -platform offscreen:https://github.com/Mahlet-Inc/hobbits/blob/c4036969066fe1720c4dda41b3d0a8acbf39ad53/tests/test_hobbits.js#L64

I definitely botched some of the build configurations and dependencies - it's possible that the runner still depends on the GUI parts of Qt because parts of hobbits are tightly coupled to Qt widgets.

ferdnyc commented 2 years ago

Running with -platform minimal may also serve, if the code doesn't actually try to show() any widgets (or can cope with those attempts failing).

-platform offscreen still requires that the system have an OpenGL-compatible GPU attached, IIRC. -platform minimal is OK with having no display hardware at all (assuming the code is also OK with that).

jakecrowley commented 2 years ago

Thank you for the help, both -platform offscreen and -platform minimal work in my case.