Mahlet-Inc / hobbits

A multi-platform GUI for bit-based analysis, processing, and visualization
https://mahlet-inc.github.io
MIT License
660 stars 45 forks source link

Use versionless Qt cmake targets #165

Closed antoniovazquezblanco closed 4 months ago

antoniovazquezblanco commented 1 year ago

Qt 5.15 introduced versionless package detection. In the future this may allow for Qt 5 & Qt6 compatibility.

https://doc.qt.io/qt-6/cmake-qt5-and-qt6-compatibility.html

antoniovazquezblanco commented 1 year ago

This replaces https://github.com/Mahlet-Inc/hobbits/pull/163

hello-adam commented 1 year ago

I guess the build pipeline uses 5.12 so this won't work. I think the solution is to add a job for a newer platform for both Qt 5.15 and Qt 6. I don't think it's a good idea to end support for the current 5.12 build yet.

hello-adam commented 1 year ago

On second thought, I guess it doesn't make sense to make this simplification until the build only supports 5.15+ - hmmm, maybe I'll just do that soonish. Anyone needing the old compatibility would likely be able to use an old tag more easily than a dev with newer Qt toolchains installed that is actively trying to add or modify something.

antoniovazquezblanco commented 1 year ago

I don't think this should be hurried. It is simply a change that took place in Qt and makes sense to adopt whenever the sw is ready to force minimum compatibility with Qt 5.15.

Let's not hurry. This pr will be open for whenever the sw is ready to do the jump in required version.

Thanks :)

antoniovazquezblanco commented 10 months ago

Just for future reference one may find the available qt versions of different platforms in: https://packages.ubuntu.com/search?keywords=qt5 https://packages.debian.org/search?keywords=qt5 https://packages.fedoraproject.org/pkgs/qt5-doc/qt5-doc/ https://software.opensuse.org/package/libqt5-qtbase

At the time of writing this comment, the only platforms that do not yet ship Qt 5.15 are: Ubuntu Focal 20.04LTS Debian Buster (Oldstable)

antoniovazquezblanco commented 4 months ago

@hello-adam how are you doing?

It seems there is not much movement regarding hobbits. It's been almost a year and no functionality seems to get pushed. I guess that this means that making hobbits Qt6 compatible can help package maintainers while not punishing users.

How do you feel about going Qt versionless with Qt > 5.15 minimum requirement now?

Thanks!

hello-adam commented 4 months ago

Thanks for the reminder! I'll set up a newer build environment and give this another shot. I've also noticed that the released *.deb package doesn't find the plugins correctly, so I'll try to fix that as well while I'm at it.

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 0.54.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

hello-adam commented 4 months ago

seemed to work fine, thanks a bunch @antoniovazquezblanco

antoniovazquezblanco commented 4 months ago

Thank you!