MahmoudAshraf97 / whisper-diarization

Automatic Speech Recognition with Speaker Diarization based on OpenAI Whisper
BSD 2-Clause "Simplified" License
3.81k stars 337 forks source link

fix ImportError in notebook #226

Closed shufinskiy closed 2 months ago

shufinskiy commented 2 months ago

Hello.

I try to run Colab notebook and I came across such a mistake:

ImportError: cannot import name 'ModelFilter' from 'huggingface_hub'

As I read in the issues of the Nemo project, this is due to the fact that when using the nemo-toolkit version 1.23.0 is incompatible with the huggingface-hub library versions higher than 0.23.2.

By default, huggingface-hub==0.24.7 is installed in Colab.

I added a forced upgrade of this library to the first cell. After reinstalling huggingface-hub, everything worked out successfully.

MahmoudAshraf97 commented 2 months ago

Thanks for your contribution, unfortunately github can't show the diff of this PR, can you take a screenshot?

shufinskiy commented 2 months ago

@MahmoudAshraf97, sure.

Before: before

After: after

shufinskiy commented 2 months ago

I see that nemo-toolkit update version 2+, but error stay without upgrade huggingface_hub version.

error

MahmoudAshraf97 commented 2 months ago

Should be fixed now, can you verify?

shufinskiy commented 2 months ago

@MahmoudAshraf97 yes, 2.0dev fixed this error.