Mahmud0808 / ColorBlendr

An Android app for customizing Material You colors on devices with Android 12+. It lets you tweak accent colors, background saturation, and more for a personalized look.
GNU General Public License v3.0
765 stars 14 forks source link

Improvements to "Force per app theme" list #66

Open Username1-a opened 5 months ago

Username1-a commented 5 months ago

1) It seems that chosen/enabled apps in "Force per app theme" list don't persist when Colorblendr service turns off/on – you need to enable per app theme for needed apps all over again;

2) Since the list shows all system+user apps, the list could be very huge – filtering options for the app list would be helpful (system+user/user/system apps and launchable (only shows system apps that can be opened)/all for system apps filter);

3) Moving chosen/enabled/highlighted apps to the top of the list would help to easier keep track of apps for which this kind of theming is enabled, as opposed to finding them while swiping through the list;

4) As opposed to Colorblendr app itself that needs to be enabled in "Force per app theme" list to correctly see/preview the theme as user makes changes to it in the app (like changing the background brightness), maybe per app theme should be enabled for Colorblendr by default?

Username1-a commented 5 months ago

And some other feature that could be helpful is:

  1. "Force per app theme" list backup/restore (saving the list of enabled apps), maybe like in Iconify (with separate backup files for Xposed tweaks and the rest of the app settings), so there could be a theme .colorblendr backup and separate "force per app theme" list backup file
Mahmud0808 commented 4 months ago

Accepted:

  1. https://github.com/Mahmud0808/ColorBlendr/commit/4ffdd39d1156944f50eb15b69b3c9b71ff94c2f1
  2. https://github.com/Mahmud0808/ColorBlendr/commit/f476b4be05f04e05db937fdaed3073f97870fdb2
  3. https://github.com/Mahmud0808/ColorBlendr/commit/b71a1d8c4d8337c898d9ffd23280ecebc7b20000

Rejected:

  1. This is what I initially did, but someone reported his ColorBlendr app keeps crashing because of it, and he doesn't want it to be selected by default. It was automatically being enabled for him even after disabling (which I couldn't reproduce), hence it's not enabled by default anymore.
  2. Backup and restore is already included with the full config. A separate backup is unnecessary. ColorBlendr can automatically update the list based on different conditions (app availability, service enabled/disabled etc).
Username1-a commented 4 months ago

5. Backup and restore is already included with the full config. A separate backup is unnecessary. ColorBlendr can automatically update the list based on different conditions (app availability, service enabled/disabled etc).

The only inconvenience with that is that since previously app list backup did not worked properly (resetting every time the service was shut off), in a lot of Colorblendr theme configs (which are great to be used when you need to change to that particular custom theme on-the-fly, kinda like "Themes" menu in Repainter) those app list changes haven't been saved

Moreover, if you install more incompatible apps (that would require "force per app theme" to be completely re-themed) you may have to manually update other existing configs

So, Iconify approach with separate configs would probably be justified here

Just a thought

Also, thank you for already made changes to the list, they are very helpful

Username1-a commented 4 months ago
  1. It seems that chosen/enabled apps in "Force per app theme" list don't persist when Colorblendr service turns off/on – you need to enable per app theme for needed apps all over again;

@Mahmud0808 Sorry for tagging, but it seems that this first issue is still persistent in version 1.4 – after Colorblendr service is turned off and then on the user choice inside "force per app theme" list is cleared, you need to re-enable apps again

Mahmud0808 commented 4 months ago
  1. It seems that chosen/enabled apps in "Force per app theme" list don't persist when Colorblendr service turns off/on – you need to enable per app theme for needed apps all over again;

@Mahmud0808 Sorry for tagging, but it seems that this first issue is still persistent in version 1.4 – after Colorblendr service is turned off and then on the user choice inside "force per app theme" list is cleared, you need to re-enable apps again

Can't reproduce.

Username1-a commented 4 months ago

Just in case, it happens when switching the service off and then clearing from the recents/stopping the Colorblenr app. Here's screen recording example of this bug:

https://github.com/Mahmud0808/ColorBlendr/assets/47947180/8a4fc3cc-0289-4eb5-912e-7f54a8358a90

When switching the service off and on immediately when the app is open, the "force per app theme" list apps are retained

Mahmud0808 commented 4 months ago

Got it, it refreshes the list on each launch. That's what makes it loose the previously selected apps.