Mahmud0808 / ColorBlendr

An Android app for customizing Material You colors on devices with Android 12+. It lets you tweak accent colors, background saturation, and more for a personalized look.
GNU General Public License v3.0
765 stars 14 forks source link

Some apps with updated material components cannot be completely re-themed through "Force per app theme" #67

Closed Username1-a closed 4 months ago

Username1-a commented 5 months ago

Looks like some apps that have updated material components cannot be themed through the "force per app theme" menu, the app background stays the same (doesn't follow Colorblendr's Black theme for example), even after force closing the app.

Examples of such apps:

  1. Copy SMS Code (https://github.com/jd1378/otphelper): —Older version 1.13.1 with old material components repaints by Colorblendr completely (including the background brightness), without using the "force per app theme" —While later updated versions (using most recent v1.13.4 in example) with updated material components cannot be completely repainted by Colorblendr even with "force per app theme" enabled for the app;

  2. MRepo (https://github.com/MRepoApp/MRepo): —Older version 2.4.3 repaints completely —While later updated versions (using most recent v2.4.6 in example) cannot be completely repainted even with "force per app theme";

  3. Open Video Editor (https://github.com/devhyper/open-video-editor): —Older version 1.0.2 repaints completely —While later updated versions (using most recent v1.1.1 in example) cannot be completely repainted even with "force per app theme";

But for example LogFox (https://github.com/F0x1d/LogFox) in newer versions with updated material components repaints just fine (so, with it's background) when using "force per app theme": —Older version 1.5.1 with old material components repaints completely without using "force per app theme" —Later versions with updated material components (using most recent LogFox v1.5.7) repaints completely using "force per app theme"

Just thought I'd let you know

(I'm using EvoX ROM, Android 13 QPR3, Colorblendr v1.3)

Username1-a commented 5 months ago

Example screenshots: Screenshot_20240408-184024_Copy SMS Code~2 Screenshot_20240408-184114_Copy SMS Code~2

Screenshot_20240408-184305_Lawnchair~2 Screenshot_20240408-184409_Lawnchair~2

Screenshot_20240408-184725_Lawnchair Screenshot_20240408-185036_Lawnchair

Screenshot_20240408-184445_Lawnchair~3 Screenshot_20240408-184600_Lawnchair~4

Mahmud0808 commented 4 months ago

So I just got some time to check this issue out. All 3 apps you mentioned are themed perfectly without even having to select them in force per app theme list. Hence closing this issue as it isn't reproducible in my case.

Username1-a commented 4 months ago

Very strange, tried the same even with reinstalling Colorblendr v1.4 and reinstalling MRepo v2.4.6 b6130fd (760) (last version, with updated material components), put everything as it is on your screenshots, tried force closing the apps and still I only get grey background

Can change background saturation changes with the slider for MRepo, but not brightness with it's slider, same with Pitch Black theme toggle

Screenshot_20240419-205323_Lawnchair Screenshot_20240419-205208_Lawnchair

Furthermore, I can't even enable MRepo in "Force per app theme" list, it just disables every time I leave the list menu. Relaunching the Colorblendr doesn't help (Other

I'm on Android 13 QPR3, EvoX Custom ROM without any other Monet mods enabled (Only have Iconify but without any changes to coloring in it)

Mahmud0808 commented 4 months ago

Some apps don't allow overlaying so these will automatically get unselected after selecting. If this issue is reproducible in more roms (and by me too), then I can look into it. Otherwise can't help.

Henry-Hiles commented 4 months ago

Some apps don't allow overlaying so these will automatically get unselected after selecting. If this issue is reproducible in more roms (and by me too), then I can look into it. Otherwise can't help.

If I know an app developer, how can they enable overlaying for their app? Thx.

Mahmud0808 commented 4 months ago

Some apps don't allow overlaying so these will automatically get unselected after selecting. If this issue is reproducible in more roms (and by me too), then I can look into it. Otherwise can't help.

If I know an app developer, how can they enable overlaying for their app? Thx.

I don't know for sure. As far as I know, split apks don't support overlaying (not sure about this). Also apps like playstore, facebook, whatsapp etc are unthemable because of resource obfuscation.

Edit: This can help you https://source.android.com/docs/core/runtime/rros