MaibornWolff / codecharta

CodeCharta visualizes multiple code metrics using 3D tree maps.

https://maibornwolff.github.io/codecharta/

BSD 3-Clause "New" or "Revised" License

183 stars 29 forks source link

CCSH - Cannot exit via CTRL+C #3355

Open ce-bo opened 1 year ago

ce-bo commented 1 year ago

Bug

Expected Behavior

WHEN I run `ccsh` command in my shell and enter CTRL+C to stop the command THEN I want the command to be exited ## Actual Behavior Nothing happens, I am stuck. ## Screenshots ## Steps to Reproduce the Problem 1. 1. 1. ## Specifications - is released in [online-demo](https://maibornwolff.github.io/codecharta/visualization/app/index.html?file=codecharta.cc.json.gz&file=codecharta_analysis.cc.json.gz): yes | no - CodeCharta Version: 1.119.0 - OS: Windows (cmd.exe, powershell, but not git bash). - Browser: -

moritz-suckow commented 10 months ago

I took a look at it and this seems to be correlated to KotlinInquirer. KInquirer uses Jline3 to handle console input in a rather old version (3.21.0). There was a very similar issue to this one at Jline3 (https://github.com/jline/jline3/issues/822) which was closed and might have fixed the problem. Since then two new versions of Jline3 were released, but KotlinInquirer did not update their dependency. I am unsure if we can fix this from our side.

fritschldwg commented 7 months ago

Follow up on the previous comment after cloning the kotlin-inquirer repo:

Just updating jline to 3.23+ doesn't fix the issue on Windows. Control-C still propagates to the kotlin-inquirer and causes errors, but can be fixed with little code changes.
Since it's unlikely that any PRs will be merged into the kotlin-inquirer repo (some from 2022 are still open), we could use a fork in codecharta (kotlin-inquirer is used via jitpack in codecharta). This would also let us fix backspacing in gitbash, which currently doesn't work.

fritschldwg commented 7 months ago

We could use one of the following solutions to address the shortcomings of the kotlin-inquirer:

~~Use alternatives to the kotlin-inquirer~~
- There are no direct alternatives to the kotlin-inquirer and extandable cli-libraries like kotlinx-cli (https://github.com/Kotlin/kotlinx-cli) are unmaintained
~~Fork the kotlin-inquirer repository and make necessary modifications~~
- Fork is not wanted
Develop our own inquirer-library
~~Incorporate a java-inquirer into our project~~
- java alternatives like text-io (https://github.com/beryx/text-io) are unmaintained (last contributions often > 10 years)

ce-bo commented 7 months ago

I think this is blocked by #3483