MaibornWolff / codecharta

CodeCharta is a visualization tool that transforms complex software architecture and code metrics into interactive, customizable visual maps, empowering everyone to communicate and analyze your codebase. Improve code quality, maintainability, and architectural decisions

https://maibornwolff.github.io/codecharta/

BSD 3-Clause "New" or "Revised" License

193 stars 30 forks source link

Feat/3668/extract inspect command #3826

Closed BenediktMehl closed 4 days ago

BenediktMehl commented 6 days ago

Create new ccsh filter "inspect"

Closes: #3668

Description

Moved functionality from modify-filter to a new 'inspection'-tool
Added the new 'inspection'-tool
Added deprecation-warnings to the old modify-filter
[x] Maybe we should add a new issue to fully remove the print functionality from the modify-filter in the future, when all users have adapted to that change?

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

[x] Changes have been manually tested
[x] All TODOs related to this PR have been closed
[x] There are automated tests for newly written code and bug fixes
[x] All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
[x] Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
[x] CHANGELOG.md has been updated

Screenshots or gifs

phanlezz commented 5 days ago

Can you ping me on Teams, if you are ready for review? I probably will get to it tomorrow 👍

phanlezz commented 5 days ago

You may need to update some gh-pages. I'm not sure how much it matters (#3801), but you should copy the updated readme content to 03-14-structuremodifier.md I'm not sure if there is a section about the ccsh tools somewhere.

On my machine, those three tests fail, because there are two extra white spaces at the start of the line. I have no idea where they are coming from, because during regular cli use, this does not occur.
grafik grafik grafik