search

MaibornWolff / codecharta

CodeCharta visualizes multiple code metrics using 3D tree maps.
https://maibornwolff.github.io/codecharta/
BSD 3-Clause "New" or "Revised" License
185 stars 29 forks source link

Missing buildings due to margin #821

Open alexhunziker opened 4 years ago

alexhunziker commented 4 years ago

Bug

Expected Behavior

Buildings should not disappear based on the margin chosen

Actual Behavior

The margin may cause buildings, which have a non-zero area metric to disappear (i.e. not be displayed).

In the screenshot below, the camera package contains a file with rloc=33 and thus should be displayed. However the folder is shown as if it was empty.

Screenshots

missing_building_cc2

missing_building_cc

Steps to Reproduce the Problem

  1. Select an AreaMetric in which small buildings exist
  2. Increase the Margin
  3. The buildings may disappear due to the margin
alschmut commented 4 years ago

Thanks @alexhunziker for adding this bug! This is actually one of the main issues using our treeMap algorithm, because it reduces all building areas in order to increase the margin around.

ce-bo commented 3 years ago

In the firefox.cc.json map there are a lot of missing buildings (e.g. the extension folder includes 90 files which are not drawn): image

RomanenkoVladimir commented 3 years ago

part of #1609, closing the issue should also close this one

BridgeAR commented 3 years ago

@RomanenkoVladimir let's keep it open for now. AFAIK it would mostly be fixed but not completely.

BridgeAR commented 1 year ago

This should be fixed by #3077. @RomanenkoVladimir or anyone else, please check if that's the case and close it accordingly.