search

MaibornWolff / metric-gardener

BSD 3-Clause "New" or "Revised" License
6 stars 0 forks source link

Count LOC for all kind of files #142

Closed ResistantBear closed 6 months ago

ResistantBear commented 7 months ago

We should provide the number of lines for files also when we have no tree-sitter grammar for the language. Apparently, this is also not supported by the raw text parser used by CodeCharta.

ce-bo commented 6 months ago

We should add the LOC metric in the output for every file that is considered as "not supported". Otherwise it would like like, that we can also calculate other metrics for those files.

Depending on the performance, we might want to introduce a cmd line argument to toggle this behavior. This would not be that important but could help us.

ResistantBear commented 6 months ago

The current approach is to have an "info" field listing all unsupported files. We could either continue to have this field and add LOC to each of the unsupported files, which definitely makes it clear that we do not support any other metrics for these files. Or we could remove the "info" field again and list these files together with the fully supported files, but only with LOC included as metric. That would be more confusing but might makes the json easier to parse for the CodeCharta-team.