MaibornWolff / metric-gardener

BSD 3-Clause "New" or "Revised" License

6 stars 0 forks source link

Refactor/366/type declaration #369

Closed BenediktMehl closed 4 months ago

BenediktMehl commented 4 months ago

Refactoring of the getTypes Methods

Closes: #366

Description

General Code clean up and complexity reduction
This Refactoring breaks some tests.
We don't know why those tests break, but think it is because of the output order of the TypeInfos from the getTypes method.
We added a test for the getTypes Method to assure correct behaviour.
And skipped the other failing test.
We will tackle this in the upcoming issue #368

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

[ ] All TODOs related to this PR have been closed
[ ] There are automated tests for newly written code and bug fixes
[ ] All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
[ ] Documentation (README.md, UPDATE_GRAMMARS.md) has been updated

Screenshots or gifs

github-actions[bot] commented 4 months ago

Coverage Report

Status	Category	Percentage	Covered / Total
🟢	Lines	91.87% (🎯 90%)	4311 / 4692
🟢	Statements	91.87% (🎯 90%)	4311 / 4692
🟢	Functions	91.46% (🎯 90%)	193 / 211
🔴	Branches	89.66% (🎯 90%)	460 / 513

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
src/parser/resolver/types/abstract-collector.ts	84.21%	50%	100%	84.21%	28-33
src/parser/resolver/types/c-sharp-collector.ts	100%	100%	100%	100%
src/parser/resolver/types/php-collector.ts	26%	100%	0%	26%	9-41, 44-45, 48-49
src/parser/resolver/types/resolver-strategy/types-query-strategy.ts	92.7%	75%	100%	92.7%	17-18, 66-68, 81-82

Generated in workflow #109