Closed davideravasi closed 1 year ago
Thanks for the PR. Left comments around the changes, hope they make sense. The builds are failing due to another reason that I'll fix up in a separate PR
This PR has been merged now to fix the build issue so if you update your fork/branch then this should resolve the errors around the failed checks
Hello, so I refactored the comment based on your suggestions. I also merged the last changes of master into my branch, tell me if looks fine and sorry for the wrong PR which I already closed, was a mistake.
So, I tried to make my comment more readable. Just a remark, at line 281 there is a comment very long that can be shrink in multiple lines if we want to follow this kind of "readable" approach. Let me know if now is ok
Thanks for letting me know. I'll fix the other comment in a separate PR
Thank you for merging it @MaikuB Just to understand, this page > https://pub.dev/packages/flutter_appauth/example Will be automatically updated with my comment in the next hours / day I imagine, or is there something else I need to do to make the comment appearing in the example on pub.dev? 🤔
Pub.dev updates when new releases are published
The class used for the documentation example https://pub.dev/packages/flutter_appauth is not mentioning if the code_challenge needs to be created by whom is consuming the library or if this happens under the hood. The comment explains that is the library which takes care of it and gives a brief explanation of why is not explicitly returned/used later in the flow
As this repository hosts two packages, please ensure the PR title starts with the name of the package that it relates to using square brackets (e.g. [flutter_appauth])