search

MaikuB / flutter_appauth

A Flutter wrapper for AppAuth iOS and Android SDKs
273 stars 246 forks source link

[flutter_appauth] use initWithPresentingWindow to fix deprecation warning #438

Closed darkdarkdragon closed 1 year ago

darkdarkdragon commented 1 year ago

[flutter_appauth] fix MacOs auth. Without that it opens regular Safari browser and can't return back.

MaikuB commented 1 year ago

I've not seen what you mention happen and following is a recording of the example app

https://github.com/MaikuB/flutter_appauth/assets/25263378/ba0aaae5-38a9-48bf-adcd-e53fa6e36910

Even so, this change does address a deprecation warning so should be merged in. As the PR title forms part of the commit message when the PR is merged in, are you able to come up with a more descriptive PR title on what this PR addresses?

darkdarkdragon commented 1 year ago

@MaikuB I'm sorry I somehow missed your comment 😕 Thanks for merging this in!