search

MaikuB / flutter_local_notifications

A Flutter plugin for displaying local notifications on Android, iOS, macOS and Linux
2.47k stars 1.4k forks source link

[flutter_local_notifications] fix: handle exception while loading resource name #2406

Closed Goddchen closed 1 month ago

Goddchen commented 2 months ago

As discussed in #2309

We deployed the fix to production and we see no more errors 🥳

Goddchen commented 2 months ago

@MaikuB I'm not that familiar with the Java world anymore. Can you point me to how to fix the failing CI job @MaikuB ?

MaikuB commented 1 month ago

It's failing as it found the code wasn't formatted to meet Google's Java formatting standards, tried to apply the formatting but then failed to push the changes. I'm not sure if this is to do with permissions on your fork and if this could be solved by changing the settings on the PR so that changes could've been pushed.

If you want to try manually fixing it yourself then you could try following https://github.com/google/google-java-format?tab=readme-ov-file#using-the-formatter

Goddchen commented 1 month ago

should be fixed now, thanks for the hint @MaikuB

MaikuB commented 1 month ago

Thanks for a lot. Appreciate that you put the effort to test the changes and contribute back