To do: Unit tests. - Githubissues

Maikuolan commented 5 years ago

Need to write unit tests for the currently available classes.

Maikuolan commented 5 years ago

Interesting.. I synced up v1 with the latest tests which were recently merged to v2, and according to the tests, the complex string handler produces some different results on different PHP versions. PHP > 5.6 produces the expected results, but we get something different for PHP <= 5.6. Not sure yet what's going on there.. Tests look good to me. Might be some different behaviour between different PHP versions for some of the functions used by the class which I hadn't accounted for before. Anyway, doing some other things tonight, but I'll investigate further tomorrow.

Maikuolan commented 4 years ago

PHP <= 5.6 failures resolved.

Maikuolan commented 4 years ago

Current coverage/progress:

Cache: Not yet covered. (Not sure whether we should bother with this particular class anyway, because it'll probably be quite tricky to do it properly, due to that it can work alongside a number of different extensions, which don't all have the same availability on all PHP versions).
ComplexStringHandler: Covered. ✔️
DelayedIO: Covered. ✔️
Demojibakefier: Covered. ✔️
Events: Covered. ✔️
L10N: Covered. ✔️
Matrix: Covered. ✔️
NumberFormatter: Covered. ✔️
Operation: Covered. ✔️
Request: Covered. ✔️
YAML: Covered. ✔️

Maikuolan commented 3 years ago

All classes (other than the Cache handler) now have tests. :-)

Marking as implemented and closing.

Maikuolan / Common

To do: Unit tests. #1