Infinite recursion in IMAPAppendMessageOperation::customFlags()

MailCore / mailcore2

MailCore 2 provide a simple and asynchronous API to work with e-mail protocols IMAP, POP and SMTP. The API has been redesigned from ground up.

Other

2.61k stars 627 forks source link

Infinite recursion in IMAPAppendMessageOperation::customFlags() #1658

Open zackj opened 7 years ago

zackj commented 7 years ago

I was cleaning up compiler warnings in a project that uses mailcore2 when I came across this on line 68 of MCIMAPAppendMessageOperation.cpp:

Array * IMAPAppendMessageOperation::customFlags() { return customFlags(); }

I'm not calling it anywhere but it seems to me that this should return mCustomFlags instead of calling itself recursively. Am I missing something obvious here?

dinhvh commented 7 years ago

Could you send a pull request to fix it? Thanks!

zackj commented 7 years ago

Done!