search

MailOnline / videojs-vast-vpaid

video.js vast plugin
MIT License
296 stars 231 forks source link

Progress of ad not shown during flash ads? #135

Open nickygerritsen opened 8 years ago

nickygerritsen commented 8 years ago

I noticed that Flash ads do not show a progress bar. Is this intended?

And is this even fixable or is this too hard?

Fetz commented 8 years ago

we can do a loading, but the problem is that some ads they load as well their own stuff so you could have multiple loading bars.

This part of handling flash vpaid is done in this project: https://github.com/MailOnline/VPAIDFLASHClient

nickygerritsen commented 8 years ago

I mean the time-bar with how long the ad takes, not the loading btw :)

Fetz commented 8 years ago

Sorry for misunderstanding.

Regarding that it should work, but since is optional some ads doesn't provide the time, then in those cases, we don't show.

http://www.iab.com/wp-content/uploads/2015/06/VPAID_2_0_Final_04-10-2012.pdf if is not implemented, the ad unit returns a -1 value. If the duration is unknown, the ad unit returns a -2. Unknown duration is typical when the user has engaged the ad

There is 2 events that provide that: VPAID 1: adRemainingTime VPAID 2 adDuration

If you have an ad that has this feature implemented and is not working with our videoplayer, please share so we can fix. I will confirm if this feature is really working

nickygerritsen commented 8 years ago

It seemed all examples on the demo page that use flash do not work currently

Fetz commented 8 years ago

Ok after looking at the code we not handling this in the plugin even if VPAIDFLASHClient is triggering this events. I doubt that I can reuse the videojs progress bar

Let me know if the first solution is ok for you or not

nickygerritsen commented 8 years ago

Yeah that's ok as we have our own progress bar for ads already using an ima plugin which we can probably reuse

Fetz commented 8 years ago

like the other issue https://github.com/MailOnline/videojs-vast-vpaid/issues/136 if the ad implements is own progress bar you could have a duplicated progress bar

nickygerritsen commented 8 years ago

For our case this does not happen at least, so if we get the events we're ok