search

MailOnline / videojs-vast-vpaid

video.js vast plugin
MIT License
296 stars 233 forks source link

Nonlinear Support #168

Open sevketufuk opened 8 years ago

sevketufuk commented 8 years ago

Are you planning to implement Nonlinear support? Due to architecture of the code it is really hard to implement it as decoupled/separated module. Regards.

Fetz commented 8 years ago

@ufucuk

Due to architecture of the code it is really hard to implement it as decoupled/separated module.

We improved a a lot by moving to browserify (like the VPAIDClients repo that are different modules) and there was an idea to move the vast part to a different repo to allow even more flexibility to be used in different players. There is a lot of margin for improvement (and contributions by everyone).

If you think something is wrong or can improved (from architecture to new features), I recommend you to contribute back :)

sevketufuk commented 8 years ago

@Fetz I've just implemented nonlinear for dailymotion's vast-client and merged today, since it is a stand alone library that was easier to use. I'll be also contributing to this repo hopefully soon.

Cheers!

Fetz commented 8 years ago

Thanks @ufucuk :+1:

andyearnshaw commented 8 years ago

@ufucuk do you have a timescale for when you might be able to contribute nonlinear support? I only ask because we're faced with either fixing the problems we were having with JWPlayer or holding out for nonlinear support in this plugin.

Adding nonlinear support ourselves would be trickier than fixing JWPlayer I think, but I'd much rather use videojs as we are not making money from showing VAST/VPAID ads.

sevketufuk commented 8 years ago

@andyearnshaw I don't have a schedule in my mind that is why I can't really say when. I'm only guessing that it would be 2 months time frame.

andyearnshaw commented 8 years ago

@ufucuk ok, thanks for the quick response :smile:.