Open mbuyan opened 8 years ago
I've tested this VAST tag on the demo page and reproduced the issue in Chrome 50.0.2661.94 for Mac. Here is the screenshot attached. The ad does not take the full height of its container
@indieveed @mbuyan is a css bug in https://github.com/MailOnline/VPAIDHTML5Client, setting the element style to the following
element.style {
position: absolute;
width: 100%;
height: 100%;
}
fixes the issue, now that I have access to the projects I will try to fix this bug
the latest version includes the fix for this
@Fetz Great! Don't you need to update built lib files?
@indieveed what you mean?
@Fetz I mean built files in bin folder like this one – https://github.com/MailOnline/videojs-vast-vpaid/blob/master/bin/videojs_4.vast.vpaid.min.js
Hi, the merged changes remove VPAIDHTML5Client from global namespace:
window.VPAIDHTML5Client = VPAIDHTML5Client;
Maybe you should add a fix for the internal dev demo (gulp serve / Browsersync), which now stops working with
(index):24 Uncaught ReferenceError: VPAIDHTML5Client is not defined
VAST(first) with link to another VAST(second) in Creatives shows ads in container with fixed height, but if I try to use second VAST on demo it's alright. I tested this VAST(first) in JWPlayer and it shows ads correct. How can I fix it?
`