search

MaineDevCoop / polkadb

The JavaScript Database, for Node.js, nw.js, electron and the browser
MIT License
0 stars 0 forks source link

Add close functionality #1

Open valyrie97 opened 4 years ago

valyrie97 commented 4 years ago

@RobHumphris would you mind recreating your pull request from NeDB for closing functionality here?

for context, I'm looking to continue the NeDB project, and add previously contentious functionality, starting with closing functionality.

RobHumphris commented 4 years ago

Unfortunately I am no longer with the organisation that own the repo the pull request was from, and don't want to risk creating any issues with them.

It should be possible to cherry pick the changes as they all seem fairly self-contained.

Sorry that I can't be more help.

valyrie97 commented 4 years ago

No problem! My first thought was to cherry pick, but I figured as I go through old PRs, I'd reach out, see if people would still want their names attached to the PRs if possible.

Thanks for the update, I'll go ahead with the merge.

RobHumphris commented 4 years ago

We went into production with those changes running on an IoT gateway, and didn't run into any problems from then on.

Good luck supporting the project, it was a really good implementation that seemed to get out of hand for the developer.