Closed mosic closed 5 years ago
@PaulLeCam Thanks for the detailed review! I agree with the proposed changes, I was aware that the PR was a bit rushed.
As for the additional APIs to remove an entry and prompting to download/save a file, could that be in a separate PR?
Either way, I'll work more on this tomorrow, for now I pushed the changes that are tested and work.
Thanks for the changes! Yes no problem having these 2 APIs as a separate PR, I don't think we need to provide these in the next release anyways so no rush adding them.
@PaulLeCam I addressed all your comments, let me know if I can do something better instead of raising errors when I'm validating the storage requests.
This adds four new calls to the SDK:
sdk.storage.set()
sdk.storage.get()
sdk.storage.list()
sdk.storage.promptUpload()
All files/string uploaded this way are streams pushed to Swarm, encrypted with libsodium.