Mainframe-Archive / mainframe-os

Mainframe OS
https://mainframeos.com
MIT License
45 stars 9 forks source link

Add the encrypted storage APIs #366

Closed mosic closed 5 years ago

mosic commented 5 years ago

This adds four new calls to the SDK:

All files/string uploaded this way are streams pushed to Swarm, encrypted with libsodium.

mosic commented 5 years ago

@PaulLeCam Thanks for the detailed review! I agree with the proposed changes, I was aware that the PR was a bit rushed.

As for the additional APIs to remove an entry and prompting to download/save a file, could that be in a separate PR?

Either way, I'll work more on this tomorrow, for now I pushed the changes that are tested and work.

PaulLeCam commented 5 years ago

Thanks for the changes! Yes no problem having these 2 APIs as a separate PR, I don't think we need to provide these in the next release anyways so no rush adding them.

mosic commented 5 years ago

@PaulLeCam I addressed all your comments, let me know if I can do something better instead of raising errors when I'm validating the storage requests.