search

MainframeOS / react-json-renderer

MIT License
37 stars 3 forks source link

Support fragments #5

Closed dawehner closed 6 years ago

dawehner commented 6 years ago

Right now this PR sadly does have a flow error. There is some discussion about this on https://github.com/facebook/flow/pull/5913 but I still couldn't make flow happy.

PaulLeCam commented 6 years ago

Thanks for your PR but I don't think it's necessary to provide it directly, as applications wanting to make use of Fragment could simply provide it among the other supported components, unless I'm missing something?

dawehner commented 6 years ago

HI Pual. Yes, applications could do that, but on the other hand, it would be nice given React.Fragment ships since react 16.1 and I expect on the longrun most of the people will use it.

PaulLeCam commented 6 years ago

Hi, sorry for the delay replying, I just got back to it. I pushed v0.6.0 that adds Fragment support, please let me know it you have any issue with it.