Open Altonss opened 2 months ago
licaon-kter
commented
2 months ago Will the app build if we remove the gms entries in .gradle files but also firebase entries from https://github.com/MaisClement/Navika_App/blob/master/pubspec.yaml ? I kinda doubt that
Fastlane structure for pics and icon and etc ( https://gitlab.com/-/snippets/1895688 ) would be nice
Altonss
commented
2 months ago Will the app build if we remove the gms entries in .gralde files but also forebase entries from https://github.com/MaisClement/Navika_App/blob/master/pubspec.yaml ? I kinda doubt that
From the readme, it seems that at least Firebase isn't essential: https://github.com/MaisClement/Navika_App#firebase
licaon-kter
commented
2 months ago that's not what I've asked :stuck_out_tongue_winking_eye:
plenty of code references Firebase
Altonss
commented
2 months ago plenty of code references Firebase
Well, then I don't understand this sentence :sweat_smile: from the readme: Navika use firebase for notifications. Firebase is not required to build the app, you can safely disable it.
licaon-kter
commented
2 months ago eg. we remove firebase from the dependencies, then we try to build this https://github.com/MaisClement/Navika_App/blob/v1.3.3/lib/main.dart#L3 or https://github.com/MaisClement/Navika_App/blob/v1.3.3/lib/main.dart#L17 will error out since it's referenced but now not found
yes, "used or not" in the app is different compared to "needed to be able to actually build the app"
Ce serait utile si cette application était disponible dans le magasin https://f-droid.org/. Je pense qu'il ne manque plus beaucoup de choses pour que cela soit possible (un premier scan a été effectué ici: https://gitlab.com/fdroid/rfp/-/issues/2709#note_1849359210):
Il faudrait aussi vérifier si la licence de Here pour la cartographie est compatible avec l'inclusion dans F-Droid.