SarahHCode commented 2 weeks ago

Pull Request

Summary

Added code to make focused pin bigger.

Changes Made

Added the code in showPins() method to make the focused discovery in URL pin bigger and make former focused pin (previously in URL) return to normal style (because setStyle() overrides or something the normal style). Also added a new variable to keep track of former focused pin. Added showPins() method to $watch in created() cycle to watch for changes in focused discovery in URL to update bigger pin. 💀

Screenshots (if applicable)

Related Issues

Checklist

Please ensure all the following steps are completed before submitting the pull request:

[ ] Code passes all existing tests
[ ] New features or changes are accompanied by appropriate tests
[ ] Code follows the established coding style and conventions
[ ] Documentation has been updated to reflect the changes (if applicable)
[ ] All new and existing tests pass locally

Additional Notes

How do I make tests for this? Plus, I am scared that with how many times showPins() is called, that the performance would suffer, so, I think that should be checked.

kim841 commented 1 week ago

Overall, très bon code! Les commentaires sont très adéquats!

As-tu eu des crash de l'application ? J'en ai eu 2 fois. Quand j'ai recommencé l'émulateur, c'était smooth.

Pour les tests, le focus du pin arrive lors de l'intéraction entre 2 écrans (ex: fiche descriptive d'un discovery & la map), e2e pourrait être une manière de tester

SarahHCode commented 1 week ago

Oui, j'ai eu des crashs... je me demande si ce serait à corriger...