implemented delete behavior for binary operator holes

just6660 commented 2 years ago

I'm not sure why there are so many edits to package-lock.json and package.json. Also I think vscode automatically formatted the code for some other sections.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nova-editor	✅ Ready (Inspect)	Visit Preview	May 10, 2022 at 6:56PM (UTC)

MajeedKazemi commented 2 years ago

a few things about the behavior of the code that you wrote:

this seems to be only added for backspace event, please add the same for a delete key stroke. make sure that you don’t have redundant code.
your behavior for the binary operator seems to be fine. good job.
please complete your pull request to fix the following as well: https://github.com/MajeedKazemi/nova-editor/issues/424 — you’ve currently worked on one or two of these, but the rest are also needed. see if you could write code so that all of them could be fixed with similar mechanisms.

MajeedKazemi / code-struct

implemented delete behavior for binary operator holes #583