MajenkoLibraries / ICSC

Inter-Chip Serial Communications
BSD 3-Clause "New" or "Revised" License
81 stars 27 forks source link

ICSC_CATCH_ALL Not working unless defined as a char < ASCII 128 #6

Open mattbsyd opened 8 years ago

mattbsyd commented 8 years ago

I was struggling to register a command using ICSC_CATCH_ALL, it would not work until i figured out that

define ICSC_CATCH_ALL 0xFF

was causing the issue

I changed to 0x7F (ASCII 127 which is the 'DEL' character) and everything worked beautifully.

I'm not a very good C/C++ programmer but I am guessing this is because #define isn't treating it as an unsigned char and thus limiting to the non-extended ASCII table.