Majic-Jungle / sapiens-mod-creation

Official tools and examples for mod creation in the game Sapiens
MIT License
54 stars 12 forks source link

Expose `serverSapien.lua` #12

Closed SirLich closed 2 years ago

SirLich commented 2 years ago

In particular, I'm interested in values to adjust for my Vanilla Tweaks mod.

In serverSapiens.lua you define a number of constants:

local pregnancySpeed = nil
local pregnancyDelaySpeed = nil
local infantAgeSpeed = nil

You later redefine these inside of serverSapien:init

    local dayLength = serverWorld:getDayLength()
    pregnancySpeed = (1.0 / (dayLength * sapienConstants.pregnancyDurationDays))
    infantAgeSpeed = (1.0 / (dayLength * sapienConstants.infantDurationDays))
    pregnancyDelaySpeed = (1.0 / (dayLength * sapienConstants.minTimeBetweenPregnancyDays))

My suggestion is at minimum make these local variables part of the exposed serverSapiens module, or potentially you could also think of defining a function like this:

function serverSapiens:getPregnancySpeed()
       return (1.0 / (dayLength * sapienConstants.pregnancyDurationDays))
end

This is shadowable and can therefor be used for whatever we need.

mjdave commented 2 years ago

fixed b21