alternatives you considered, etc...These targets (Nano33 BLE, PortentaH7) are using Mbed as a base and a compatibility layer for Arduino. In this case, both platforms defines __MBED__ and ARDUINO are set.
Fix for #38
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Your Environment
Library Version:
3.2.4
Arduino IDE version:
1.8.3
Hardware model/type:OS and Version:
Windows10
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR.
This is a reminder of what we are expecting before merging your code.
[x] Code compiles correctly/with no errors
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added or extended necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules
Tested compiling for Nano, Uno, Nano33 BLE, PortentaH7, ESP82 Generic
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what
MajicDesigns
commented
3 years ago
Proposed changes
alternatives you considered, etc...These targets (Nano33 BLE, PortentaH7) are using Mbed as a base and a compatibility layer for Arduino. In this case, both platforms defines
__MBED__andARDUINOare set. Fix for #38Types of changes
What types of changes does your code introduce? Put an
xin the boxes that apply [x] Bugfix (non-breaking change which fixes an issue) [ ] New feature (non-breaking change which adds functionality) [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)Your Environment
Library Version: 3.2.4 Arduino IDE version: 1.8.3 Hardware model/type: OS and Version: Windows10
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. This is a reminder of what we are expecting before merging your code. [x] Code compiles correctly/with no errors [ ] I have added tests that prove my fix is effective or that my feature works [ ] I have added or extended necessary documentation (if appropriate) [ ] Any dependent changes have been merged and published in downstream modulesTested compiling for Nano, Uno, Nano33 BLE, PortentaH7, ESP82 Generic
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what