search

MajicDesigns / MD_MAX72XX

LED Matrix Library
GNU Lesser General Public License v2.1
307 stars 122 forks source link

Declare header files for PlatformIO #47

Closed ivankravets closed 2 years ago

ivankravets commented 2 years ago

Hi,

Please accept this PR that adds header files according to https://docs.platformio.org/en/latest/librarymanager/config.html#headers

Developers will see them soon in the new version of PlatformIO Package Registry.

Thanks in advance!

MajicDesigns commented 2 years ago

I don't believe this change is correct. There is nothing in the MD_MAX72xx library as distributed that is AVR specific, so the platform is not just "atmelavr", The library has been used on alternative architectures and works providing the standard SPI is present.

I do note, however, that the current file is using atmelavr, so the question is what is the indicator for a platform agnostic library? From the link above: If the library is compatible with the all platforms, then do not declare this field or use symbol: `"platforms": ""`