search

MajicDesigns / MD_MIDIFile

Standard MIDI Files (SMF) Processing Library
GNU Lesser General Public License v2.1
108 stars 38 forks source link

Handling long midi messages; fix tick calculation #7

Closed rfoschini closed 5 years ago

MajicDesigns commented 5 years ago

Can you please explain the source and reason for the changes to the tick calculation. I understand 'by experimentation' but if this is to be be rolled out there should be some source quoted or other reference. For example, does http://www.deluge.co/?q=midi-tempo-bpm or https://web.wpi.edu/Pubs/E-project/Available/E-project-010215-120510/unrestricted/MIDI_IQP_FINAL_YONG_PIAO.pdf or https://github.com/vishnubob/python-midi#Side_Note_What_is_a_MIDI_Tick support your case?

rfoschini commented 5 years ago

The explanation was in the commit comment, but i rewrite it: Ticks surely depends on "MIDI Tempo", but are independent from "MIDI Time Signature". In other terms, "a quarter" is equally long as for 2/4 as for 4/4.

Il sab 6 lug 2019, 08:54 Marco Colli notifications@github.com ha scritto:

Reopened #7 https://github.com/MajicDesigns/MD_MIDIFile/pull/7.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MajicDesigns/MD_MIDIFile/pull/7?email_source=notifications&email_token=AMRDQLMB4UD4CGET3VNQRKLP6A6T5A5CNFSM4H6ST2O2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSLNMG7A#event-2463810428, or mute the thread https://github.com/notifications/unsubscribe-auth/AMRDQLKZW2XVPG5J6JI6NTLP6A6T5ANCNFSM4H6ST2OQ .

MajicDesigns commented 5 years ago

OK. I can't see your commit comment until I merge the code. On the other hand, I can see your merge / my pull comment.