search

MajicDesigns / MD_Parola

Library for modular scrolling LED matrix text displays
GNU Lesser General Public License v2.1
438 stars 135 forks source link

Wipe does not work for one segment (zone) #11

Closed petervflocke closed 7 years ago

petervflocke commented 7 years ago

Hi Marco,

Testing your great library I found out that wipe (PA_WIPE) effect does not work for one segment display nor for one segment zone area. Environment: ESP32 + MAX7219 + USE_ICSTATION_HW

How to reproduce: Change the example Parola_Animation_Catalog example like this

define MAX_DEVICES 1

in the sCatalog table shorten the psz from "WIPE" to "W" e.g. { PA_WIPE, "W", 5, 1 },

The program hangs and does not leave the animation, stays there for ever. I haven't yet troubleshoot this, juts wanted to let you know :)

...anyway great job! P.

MajicDesigns commented 7 years ago

Verified this behaviour only occurs with centered text. Please confirm this is the same on your setup.

MajicDesigns commented 7 years ago

Similar behavior found for SCAN and GROW effects. Should now be fixed and uploaded to the repository.

petervflocke commented 7 years ago

Verified this behaviour only occurs with centered text. Please confirm this is the same on your setup.

That's right - forgot to mentioned this. Thank you for posting patches.