MajicDesigns / MD_Parola

Library for modular scrolling LED matrix text displays
GNU Lesser General Public License v2.1
433 stars 135 forks source link

Opening and Closing animation behaves identical #68

Closed woeperbe closed 4 years ago

woeperbe commented 4 years ago

Subject of the issue

Opening and Closing animation behaves identical

Your Environment

Library Version: 3.2 Hardware model/type: NodeMcu FC16 *OS and Version: Win 10 and Microsoft Visual Studio

Expected Behaviour

Close should scroll the other way

Actual Behaviour

Close animates identical to Open

MajicDesigns commented 4 years ago

Please provide example code that shows this problem.

Also make sure you read issue #56.

woeperbe commented 4 years ago

Yes` I did read that issue #56 Attached is the part of code that displays the animated string AnimateString.txt

The Opening and Closing animation behaves identical I think Closing should scroll in the other way

MajicDesigns commented 4 years ago

ok. What are the ACTUAL scroll effects you are trying to use? What is the value of EEP.scrollmodeout ans EEP.scrollmodein?

woeperbe commented 4 years ago

scrollmodein is -->{PA_OPENING,8, "Opening"} scrollmodeouit --> {PA_CLOSING,8, "Closing"}

it would be nicer if the closing did it from border to middle of display instead of now going like opening from middle to border of the display.

I made a video of this animation mode in and out with PA_OPENING and PA_CLOSING

https://share.icloud.com/photos/0y4ViqVR9jV2gwpa6x_L2u_ng

image

woeperbe commented 4 years ago

i found out that i didn’t understand how the animation for in and out works. my apologies for the trouble if i use opening for in and out it works like i would it ....

MajicDesigns commented 4 years ago

You discovered what I was going to write.

woeperbe commented 4 years ago

thanks for your perfect support .

Greetings, Marc Buffet

On 9 Jun 2020, at 21:53, Marco Colli notifications@github.com wrote:



You discovered what I was going to write.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/MajicDesigns/MD_Parola/issues/68#issuecomment-641534919, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKXOBGOBALMBPB4TQ3PZ5BTRV2HJNANCNFSM4NYE57LA.